dotnet/orleans

SMS events lost in case of serialization failures with no failure indication if FireAndForgetDelivery=true

Open

#1,286 建立於 2016年1月14日

在 GitHub 查看
 (21 留言) (0 反應) (0 負責人)C# (10,777 star) (2,123 fork)batch import
bughelp wanted

描述

Reported by @onionhammer.

If FireAndForgetDelivery is set to true, there is no indication to the producer (and to consumer) in case the message payload fails to serialize. The Task returned to producer is successfully resolved before the runtime attempts to send the message.

A potential solution is to resolve the Task returned to producer only after the message is successfully sent or delivered.

貢獻者指南

技術棧
csharp
領域
backendperformance
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Orleans runtime basicsC# async/awaitSerialization concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the Orleans runtime code related to message delivery and serialization, particularly the FireAndForgetDelivery option. Look into how the Task is currently returned to the producer and where serialization occurs. The proposed solution is to defer resolving the Task until after the message is successfully sent. This may involve changes in the messaging pipeline, such as in the `MessagingRuntime` or `StreamProviderImpl` classes. Additionally, ensure that the fix handles failures appropriately, possibly by throwing or logging the serialization error.