dotnet/msbuild

WriteOnlyWhenDifferent should check with the same encoding

Open

#8,361 建立於 2023年1月27日

在 GitHub 查看
 (1 留言) (0 反應) (1 負責人)C# (5,062 star) (1,364 fork)batch import
Area: TasksPartner requestbackloghelp wantedtriaged

描述

The encoding is missing on the check for WriteOnlyWhenDifferent https://github.com/dotnet/msbuild/blob/56087a97257fab6a67d110a7b2c4116f707325ee/src/Tasks/FileIO/WriteLinesToFile.cs#L102 while it's present on the subsequent write: https://github.com/dotnet/msbuild/blob/56087a97257fab6a67d110a7b2c4116f707325ee/src/Tasks/FileIO/WriteLinesToFile.cs#L121

貢獻者指南

技術棧
csharp
領域
build system
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C#
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
The issue is located in src/Tasks/FileIO/WriteLinesToFile.cs. The bug is on line 102, where the WriteOnlyWhenDifferent check does not include the encoding parameter, unlike the write on line 121. The fix is to add the encoding parameter to the comparison. The issue has an assignee but no linked PR; check with the assignee or maintainers for current status.
WriteOnlyWhenDifferent should check with the same encoding · dotnet/msbuild#8361 | Good First Issue