dotnet/msbuild

Better diagnostic logging in RAR when marking CopyLocal=false

Open

#1,485 建立於 2016年12月15日

在 GitHub 查看
 (1 留言) (4 反應) (0 負責人)C# (5,062 star) (1,364 fork)batch import
Area: DebuggabilityArea: LoggingArea: Task: Resolve Assembly References (RAR)User Experiencehelp wantedtriaged

描述

Sometimes it is very difficult to understand why some transitive dependencies are copied to the output directory while others aren't.

It would greatly help to improve logging in this code: https://github.com/Microsoft/msbuild/blob/xplat/src/XMakeTasks/AssemblyDependency/Reference.cs#L1226-L1247

Specifically, we already list all source items in the log: https://github.com/Microsoft/msbuild/blob/xplat/src/XMakeTasks/AssemblyDependency/ResolveAssemblyReference.cs#L1645 It would be nice to also print their Private metadata if present.

This way we can know which one specified their Private=false and let to exclusion. Otherwise we have to double-check in the log elsewhere what the metadata was. It's possible but hard to use.

貢獻者指南

技術棧
csharp
領域
build systemtooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C#MSBuild internals
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue requests improved diagnostic logging in MSBuild's ResolveAssemblyReference task. Specifically, when marking CopyLocal=false, the logging should print the Private metadata of source items to help understand why transitive dependencies are excluded. The code to modify is in Reference.cs lines 1226-1247 and ResolveAssemblyReference.cs line 1645. The goal is to add logging of Private metadata when present, without changing behavior. Look at the linked code and add appropriate diagnostic messages.