dotnet/aspnetcore

TestServer.CreateClient : the HttpClient created didn't support well the cancellation.

Open

#5,938 建立於 2018年9月17日

在 GitHub 查看
 (4 留言) (1 反應) (0 負責人)C# (10,653 fork)batch import
affected-fewarea-hostingarea-networkingbughelp wantedseverity-minor

倉庫指標

Star
 (37,933 star)
PR 合併指標
 (平均合併 16天 9小時) (30 天內合併 258 個 PR)

描述

Hello,

I just found a nasty bug on HttpClient created from TestServer. When I call a request which took 2 seconds if I cancel it after one second. The client created by test server didn't throw an OperationCancelledException.

Here the code with real httpClient :

var httpClient = new HttpClient();
using (var cts = new CancellationTokenSource(TimeSpan.FromSeconds(1)))
{
    var request = new HttpRequestMessage
    {
        Method = HttpMethod.Get,
        RequestUri = new Uri("http://localhost:4242/TimeoutTest/Action2Secs")
     };
     await httpClient.SendAsync(request, HttpCompletionOption.ResponseContentRead, cts.Token);
}

The same code with client created by the class TestServer.

var httpClient = new testServer.CreateClient();
using (var cts = new CancellationTokenSource(TimeSpan.FromSeconds(1)))
{
    var request = new HttpRequestMessage
    {
        Method = HttpMethod.Get,
        RequestUri = new Uri("http://localhost:4242/TimeoutTest/Action2Secs")
     };
     await httpClient.SendAsync(request, HttpCompletionOption.ResponseContentRead, cts.Token);
}

貢獻者指南