dotnet/aspnetcore

NotifyOnCompleted does not catch exceptions, may abort the response/connection

Open

#5,885 建立於 2018年3月7日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)C# (37,933 star) (10,653 fork)batch import
affected-very-fewarea-networkingbugfeature-httpsyshelp wantedseverity-nice-to-have

描述

NotifyOnCompleted should catch and log its own exceptions as to not disrupt the normal request flow. It doesn't.

https://github.com/aspnet/HttpSysServer/blob/336e85d19abcdf3ec3a024cb9431c768a4e5d494/src/Microsoft.AspNetCore.Server.HttpSys/MessagePump.cs#L204-L214 https://github.com/aspnet/HttpSysServer/blob/336e85d19abcdf3ec3a024cb9431c768a4e5d494/src/Microsoft.AspNetCore.Server.HttpSys/FeatureContext.cs#L586-L591

It also fires before the response is flushed/disposed so these exceptions may abort the response/connection. Compare to https://github.com/aspnet/KestrelHttpServer/pull/2324

貢獻者指南

技術棧
csharp
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C#ASP.NET Core
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Review the referenced code in MessagePump.cs (lines 204-214) and FeatureContext.cs (lines 586-591) to understand how NotifyOnCompleted is invoked. The issue states that exceptions in NotifyOnCompleted are not caught, which can abort the response. Look at the linked KestrelHttpServer pull request #2324 for a similar fix. Implement a try catch block that logs exceptions and ensures the normal request flow is not disrupted.
NotifyOnCompleted does not catch exceptions, may abort the response/connection · dotnet/aspnetcore#5885 | Good First Issue