dotnet/aspnetcore
在 GitHub 查看NotifyOnCompleted does not catch exceptions, may abort the response/connection
Open
#5,885 建立於 2018年3月7日
affected-very-fewarea-networkingbugfeature-httpsyshelp wantedseverity-nice-to-have
倉庫指標
- Star
- (37,933 star)
- PR 合併指標
- (平均合併 16天 9小時) (30 天內合併 258 個 PR)
描述
NotifyOnCompleted should catch and log its own exceptions as to not disrupt the normal request flow. It doesn't.
https://github.com/aspnet/HttpSysServer/blob/336e85d19abcdf3ec3a024cb9431c768a4e5d494/src/Microsoft.AspNetCore.Server.HttpSys/MessagePump.cs#L204-L214 https://github.com/aspnet/HttpSysServer/blob/336e85d19abcdf3ec3a024cb9431c768a4e5d494/src/Microsoft.AspNetCore.Server.HttpSys/FeatureContext.cs#L586-L591
It also fires before the response is flushed/disposed so these exceptions may abort the response/connection. Compare to https://github.com/aspnet/KestrelHttpServer/pull/2324