dotnet/aspnetcore

Add possibility to inject json reviver function in Typescript client

Open

#5,321 建立於 2018年7月26日

在 GitHub 查看
 (3 留言) (2 反應) (0 負責人)C# (37,933 star) (10,653 fork)batch import
affected-very-fewapi-suggestionarea-signalrenhancementhelp wantedseverity-minor

描述

Currently there is no possibility to customize in any way the behavior of JsonHubProtocol. It could pass a reviver function to the JSON.parse method. If a user could inject such function to the JsonHubProtocol it would be much easier to perform any data transformation (like converting date strings to Date objects).

貢獻者指南

技術棧
typescriptjavascript
領域
frontendapi
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
TypeScriptJSON
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the TypeScript client's JsonHubProtocol implementation, likely in the SignalR directory under clients/ts. The goal is to allow users to pass a reviver function to JSON.parse. Start by locating the file that contains the protocol's parse method and understand how JSON is currently deserialized. Then, consider adding an optional reviver parameter to the constructor or parse method, and pass it to JSON.parse. Ensure backward compatibility by making it optional and update the type definitions accordingly. Check existing tests to see how to add test coverage for the new parameter.