dotnet/aspnetcore
在 GitHub 查看Stop using InvalidOperationExceptions to signal invalid ASCII during parsing
Open
#4,736 建立於 2018年7月19日
affected-very-fewarea-networkingenhancementfeature-kestrelhelp wantedseverity-nice-to-have
倉庫指標
- Star
- (37,933 star)
- PR 合併指標
- (平均合併 16天 9小時) (30 天內合併 258 個 PR)
描述
GetAsciiStringNonNullCharacters() currently throws an InvalidOperationException fo invalid or chacters, and the parsing logic catches these InvalidOperationExceptions at various layers to handle the bad request appropriately.
Ideally we could switch to calling a TryGetAsciiStringNonNullCharacters method, but if propagating failure down the stack proves too difficult, we should at least move to a custom exception type so we don't end up obscuring real product bugs by inadvertently swallowing InvalidOperationExceptions thrown by other methods.