dotansimha/graphql-code-generator

Interfaces forcing c# 8.0, is this intended?

Open

#5,600 建立於 2021年2月24日

在 GitHub 查看
 (1 留言) (1 反應) (0 負責人)TypeScript (10,341 star) (1,295 fork)batch import
help wantedkind/enhancementplugins

描述

Describe the bug When we have an interface in the graphl schema the generated c# interface properties will have a public prefix making them a c# 8.0 feature.

Schema

interface Product {
  articles: [Article!]!
}

C#

public interface Product {
      [JsonProperty("articles")]
      public List<Article> articles { get; set; }
}

I guess the publicpart here should probably be omitted? Or is this intended?

  1. My GraphQL schema:
# Put your schema here
  1. My GraphQL operations:
# Put your operations here
  1. My codegen.yml config file:
overwrite: true
schema: "https://somedomain/graphql"
documents: "./src/graphql/**/*.graphql"
generates:
  ./src/GraphQL/Client/GraphQLClientServices.generated.cs:
    config:
      namespaceName: SomeNameSpace
      typesafeOperation: false
    plugins:
      - c-sharp
      - c-sharp-operations

Expected behavior I expect the output to not include the public part.

Environment:

  • OS: Windows / Git Bash
"@graphql-codegen/c-sharp-operations": "^1.18.0",
"@graphql-codegen/cli": "^1.20.1",
"@graphql-codegen/typescript": "^1.20.2",
"@graphql-codegen/typescript-graphql-request": "^3.0.2",
"@graphql-codegen/typescript-operations": "^1.17.14",
  • NodeJS: v14.15.1

貢獻者指南

技術棧
csharpgraphqltypescript
領域
developer experiencetooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Knowledge of GraphQL codegenFamiliarity with C# syntax
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The bug is in the C# code generation plugin of graphql code generator. The issue reports that interface properties are generated with a 'public' access modifier, which is a C# 8.0 feature. The expected behavior is to omit the 'public' keyword. To fix, locate the C# plugin code, likely in the packages/plugins/c sharp directory. In the template or generator logic that outputs interface properties, remove the 'public' access modifier. Check for any conditional logic that might add 'public' only in certain contexts. Test the change with a sample GraphQL schema containing an interface.