dotansimha/graphql-code-generator-community

typescript-react-apollo: Invalid TypeScript output when both withHOC and useTypeImports are true

Open

#100 建立於 2020年12月17日

在 GitHub 查看
 (3 留言) (2 反應) (0 負責人)TypeScript (195 fork)github user discovery
help wanted

倉庫指標

Star
 (136 star)
PR 合併指標
 (PR 指標待抓取)

描述

Describe the bug

When using typescript-react-apollo plugin, and enabling both withHOC and useTypeImports output is not a valid TypeScript file:

import * as ApolloReactHoc from '@apollo/client/react/hoc';
import type * as ApolloReactHoc from '@apollo/client/react/hoc';

To Reproduce Steps to reproduce the behavior:

  1. Open live-demo
  2. Choose the Operations types template
  3. Change the config to one below
  1. My GraphQL schema:
# Default from demo
  1. My GraphQL operations:
# Default from demo
  1. My codegen.yml config file:
generates:
  types-and-hooks.tsx:
    config:
      withHOC: true
      useTypeImports: true
    plugins:
      - typescript
      - typescript-react-apollo

Expected behavior

Only this line should be in the output:

import * as ApolloReactHoc from '@apollo/client/react/hoc';

Actual behavoir Both lines are in the output:

import * as ApolloReactHoc from '@apollo/client/react/hoc';
import type * as ApolloReactHoc from '@apollo/client/react/hoc';

Environment: Using the live-demo reproduces it

  • OS:
  • @graphql-codegen/...:
  • NodeJS:

Additional context

貢獻者指南