donnemartin/dev-setup

For all installation scripts, exit immediately if a command exits with a non-zero status

Open

#25 建立於 2016年5月29日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Python (5,984 star) (1,162 fork)batch import
enhancementhelp wanted

描述

it's important for a script to exit immediately if a command exits with a non-zero status, otherwise results are unpredictable.

this can be achieved by adding set -e at the beginning of all bash scripts

貢獻者指南

技術棧
shell
領域
devopsdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic bash scriptingfamiliarity with git workflow
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
90
研究方向
The issue requests adding `set e` to all bash scripts in the repository to ensure they exit on errors. To implement, locate all `.sh` files in the repo (e.g., using `find . name "*.sh"`), then add `set e` at the top of each script after the shebang line. Verify changes by running a few scripts to ensure they behave correctly on failure. The repo is https://github.com/donnemartin/dev setup, and the scripts are likely in the root or a scripts directory.