diesel-rs/diesel

First Rust example code on the website is unidiomatic

Open

#2,451 建立於 2020年7月6日

在 GitHub 查看
 (4 留言) (1 反應) (0 負責人)Rust (12,054 star) (1,003 fork)batch import
documentationhelp wanted

描述

The first Rust code example, also available under examples/postgres/getting_started_step_1, is using .ok(); to discard the error case of a Result. If ignoring any errors is intentional, that line should be updated from

dotenv().ok();

to

let _ = dotenv();

Otherwise, the .ok() should be replaced by something else (maybe .expect("dotenv setup to be successful")).

Checklist

  • I have already looked over the issue tracker for similar issues.
  • This issue can be reproduced on Rust's stable channel. (Your issue will be closed if this is not the case) N/A

貢獻者指南

技術棧
rust
領域
documentation
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
95
研究方向
The issue is to update the first Rust example code in `examples/postgres/getting started step 1/src/lib.rs`. The current line `dotenv().ok();` should be changed to either `let = dotenv();` or `dotenv().expect("dotenv setup to be successful");`. The contributor should open a pull request making this change. No additional investigation is needed beyond reading the issue and the linked file.