diasurgical/DevilutionX

Refactor 31 lines occurring 2 times in 2 files: drlg_l2.cpp, drlg_l4.cpp

開放

#1,997 建立於 2021年5月17日

 (6 則留言) (0 個反應) (0 位負責人)C++ (743 個分叉)batch import
good first issuehelp wanted

倉庫指標

星標
 (7,255 顆星)
PR 合併指標
 (平均合併 2天 12小時) (30 天內合併 15 個 PR)

描述

I've selected for refactoring 31 lines of code which are duplicated in 2 file(s) (1, 2). Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Code Once guideline rating! 👍

Here's the gist of this guideline:

  • Definition 📖 Do not copy code.
  • Why❓ When code is copied, bugs need to be fixed in multiple places. This is both inefficient and a source of regression bugs.
  • How 🔧 Avoid duplication by never copy/pasting blocks of code and reduce duplication by extracting shared code, either to a new unit or introduce a superclass if the language permits.

You can find more info about this guideline in Building Maintainable Software. 📖


Good luck and happy coding! :shipit: :sparkles: :100:

貢獻者指南