[Feature Request]Fix potential float -> double casting issue and align in expression with comparator "=" implementation · delta-io/delta#5227

(6 留言) (0 反應) (1 負責人)Scala (8,807 star) (2,100 fork)batch import

enhancementgood first issuekernel

描述

Feature request

Which Delta project/connector is this regarding?

Overview

In https://github.com/delta-io/delta/pull/5186, we are kind of customizing the type check and value comparison among numerics.

Technically we could streamline the implementation via a refactor to 1.figure out the narrowest type 2.transform the expression via implicit cast expression 3.simplify the value comparision.

Doing so today will have 1 test failure fails due to float -> double convertion 84.08 -> 84.08000183105469 We need to investigate this logic in implicit cast and then do refactoring to unify the expression logic

Motivation

Further details

Willingness to contribute

The Delta Lake Community encourages new feature contributions. Would you or another member of your organization be willing to contribute an implementation of this feature?

Yes. I can contribute this feature independently.
Yes. I would be willing to contribute this feature with guidance from the Delta Lake community.
No. I cannot contribute this feature at this time.

貢獻者指南

技術棧: scalajava
領域: backenddata
議題類型: feature
難度: 4
預計時間: 1-2 days
活動狀態: active
清晰度: mostly clear
前置要求: ScalaDelta Kernelfloating point arithmeticexpression evaluation
新手友善度: 20
研究方向: Investigate the test failure caused by float to double conversion (84.08 > 84.08000183105469) in the implicit cast logic. Review PR #5186 to understand the current type check and value comparison implementation. The goal is to refactor the expression logic to first determine the narrowest numeric type, then apply implicit cast, and finally simplify comparison. Focus on unifying the comparator '=' implementation across numeric types in the Delta Kernel.