delta-io/delta

[Kernel][Testing] Add more thorough testing for DataType.toJson

Open

#2,313 建立於 2023年11月20日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)Scala (8,807 star) (2,100 fork)batch import
enhancementgood first issuekernel

描述

Feature request

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Overview

All of our DataType classes provide toJson which serializes the type following the delta protocol schema serialization rules https://github.com/delta-io/delta/blob/master/PROTOCOL.md#schema-serialization-format. We use this method to serialize the physical and logical schemas in ScanStateRow.

toJson is only tested by the 2 round-trip tests in DefaultJsonHandlerSuite. We should add more thorough tests for toJson.

貢獻者指南

技術棧
無
領域
testing
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Scala or Java programmingDelta protocol schema serializationExisting test suite structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Start by examining the existing `DefaultJsonHandlerSuite` to understand the current round trip tests for `toJson`. Then identify all `DataType` subclasses and ensure each has a test case that verifies the serialization matches the Delta protocol schema serialization format. Pay attention to edge cases like nested types. Refer to the protocol specification at https://github.com/delta io/delta/blob/master/PROTOCOL.md#schema serialization format for exact rules.
[Kernel][Testing] Add more thorough testing for DataType.toJson · delta-io/delta#2313 | Good First Issue