Invalid validation keywords and types · dareid/chakram#27

(4 留言) (0 反應) (0 負責人)JavaScript (907 star) (100 fork)batch import

enhancementhelp wanted

描述

    it("should list all avilable players", function () {
        var responseStructure = {
            type: "array",
            properties:{
                enabled : {type:"string"},  //This is expected to be an integer, but test passes
                defaultLanguage :{type:"integer"},
                defaultCurrency :{type:"integer"},
                lastname :{type:"string"},
                firstname:{type:"string"},
                passwordSalt:{type:"string"},
                password:{type:"string"},
                email:{type:"string"},
                id:{type:"string"} //Also this, expected to be an integer, but it passes the test
            }
        }
        var response = chakram.get(endpoint);
        return expect(response).to.have.schema(playerDataStructure);

I observed that the properties are not checked even when the properties expected doesn't match the types in the reponse, the test still passes.

貢獻者指南

技術棧: javascript
領域: testing
議題類型: bug
難度: 2
預計時間: 1-3 hours
活動狀態: stale
清晰度: mostly clear
前置要求: Understanding of JSON schema validationFamiliarity with chakram's test structure
新手友善度: 40
研究方向: Investigate the schema validation logic in chakram's source code, likely in `lib/schema.js` or similar. The issue describes that properties are not being validated against their types. Look for where `type` and `properties` are checked, and ensure that the validator correctly enforces type constraints. Also check the existing test suite for schema validation to see if there are tests that pass incorrectly. The issue is old (2015), so the code may have changed; verify if the bug still exists in the current version.