dapr/dapr

[E2E] Fix Makefile to allow 'make test-e2e-all' to work on Windows + Minikube + MinGW + GitBash

Open

#865 建立於 2019年12月3日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Go (25,672 star) (2,064 fork)batch import
P3area/release-enggood first issuekind/bugsize/XStriaged/resolved

描述

Current behavior

Issue: Windows + minikube + MinGW + GitBash + make (gets stuck)

asouza@ASOUZA-DESKTOP MINGW64 /c/Code/dapr/dapr (master)
$ make test-e2e-all
DAPR_TEST_NAMESPACE=dapr-tests DAPR_TEST_TAG=dev DAPR_TEST_REGISTRY=docker.io/artursouza DAPR_TEST_MINIKUBE_IP= go test -v -tags=e2e ./tests/e2e/...

Workaround: see how I had to manually run the same command but set the minikube ip for it to work. This seems to be a fix we need in order to get this make target to work on Windows + minikube.

asouza@ASOUZA-DESKTOP MINGW64 /c/Code/dapr/dapr (master)
DAPR_TEST_NAMESPACE=dapr-tests DAPR_TEST_TAG=dev DAPR_TEST_REGISTRY=docker.io/artursouza DAPR_TEST_MINIKUBE_IP="172.17.86.11" go test -v -tags=e2e ./tests/e2e/...
=== RUN   TestBindings
--- PASS: TestBindings (1.55s)
PASS
ok      github.com/dapr/dapr/tests/e2e/bindings 42.259s
=== RUN   TestHelloDapr
=== RUN   TestHelloDapr/green_dapr
=== RUN   TestHelloDapr/blue_dapr
--- PASS: TestHelloDapr (0.52s)
    --- PASS: TestHelloDapr/green_dapr (0.51s)
    --- PASS: TestHelloDapr/blue_dapr (0.01s)
=== RUN   TestScaleReplicas
--- PASS: TestScaleReplicas (6.01s)
=== RUN   TestScaleAndRestartInstances
--- PASS: TestScaleAndRestartInstances (9.03s)
PASS
ok      github.com/dapr/dapr/tests/e2e/hellodapr        (cached)
=== RUN   TestServiceInvocation
=== RUN   TestServiceInvocation/Test_singlehop_for_callee-0
=== RUN   TestServiceInvocation/Test_singlehop_for_callee-1
=== RUN   TestServiceInvocation/Test_multihop
--- PASS: TestServiceInvocation (0.03s)
    --- PASS: TestServiceInvocation/Test_singlehop_for_callee-0 (0.01s)
    --- PASS: TestServiceInvocation/Test_singlehop_for_callee-1 (0.01s)
    --- PASS: TestServiceInvocation/Test_multihop (0.01s)
PASS
ok      github.com/dapr/dapr/tests/e2e/service_invocation       (cached)
=== RUN   TestServiceInvocation
=== RUN   TestServiceInvocation/Test_get_save_delete_with_empty_request_response_for_single_app_and_single_hop
=== RUN   TestServiceInvocation/Test_save_get_and_delete_a_single_item_for_single_app_and_single_hop
=== RUN   TestServiceInvocation/Test_save_get_and_delete_on_multiple_items_for_single_app_and_single_hop
--- PASS: TestServiceInvocation (0.57s)
    --- PASS: TestServiceInvocation/Test_get_save_delete_with_empty_request_response_for_single_app_and_single_hop (0.01s)
    --- PASS: TestServiceInvocation/Test_save_get_and_delete_a_single_item_for_single_app_and_single_hop (0.02s)
    --- PASS: TestServiceInvocation/Test_save_get_and_delete_on_multiple_items_for_single_app_and_single_hop (0.03s)
PASS
ok      github.com/dapr/dapr/tests/e2e/stateapp 17.397s
?       github.com/dapr/dapr/tests/e2e/utils    [no test files]

Expected Behavior

The following command should execute all tests correctly on Windows + Minikube + MinGW + GitBash $ make test-e2e-all

貢獻者指南

技術棧
goshelldockerkubernetes
領域
backendtestingbuild system
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Makefileshell scriptingWindows/MinGW basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
Examine the Makefile target 'test e2e all' in the root directory or tests/Makefile. The command currently runs 'go test v tags=e2e ./tests/e2e/...' without setting DAPR TEST MINIKUBE IP. On Windows/MinGW, this environment variable is needed; it can be detected via $(shell uname) or checking for OSTYPE. Modify the Makefile to automatically set DAPR TEST MINIKUBE IP by running 'minikube ip' and using that value when not already set. This should resolve the hang on Windows.