cube-js/cube

Extra brackets need to be specified when using dynamic measures

Open

#6,064 建立於 2023年1月26日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Rust (1,965 fork)batch import
help wanted

倉庫指標

Star
 (19,563 star)
PR 合併指標
 (平均合併 5天 16小時) (30 天內合併 138 個 PR)

描述

Is your feature request related to a problem? Please describe. Example of schema:

"sales":{
   "sql":"sum(${CUBE}."Sales")"
},
"wholesaleCost":{
   "sql":"sum(${CUBE}."WholesaleCost")"
},
"profit":{
   "sql":"${sales} - ${wholesaleCost}"
},
"someCoef":{
   "sql":"${profit} / ${sales}"
}

This schema is not working. someCoef generates wrong formula${sales} - ${wholesaleCost}/${sales} while correct is (${sales} - ${wholesaleCost})/${sales} It can be fixed in 2 ways:

  1. someCoef sql should be (${profit}) / ${sales} (profit inside brackets)
  2. profit sql should be (${sales} - ${wholesaleCost}) (whole formula inside brackets)

Describe the solution you'd like Cube should check and automatically add brackets if needed

貢獻者指南