cube-js/cube

Schema Compiler - Column names in Hebrew: support schema generation for non ASCII table names

開放

#5,174 建立於 2022年8月27日

 (3 則留言) (2 個反應) (0 位負責人)Rust (1,965 個分叉)batch import
help wanted

倉庫指標

星標
 (19,563 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

Describe the bug When generating my cube with the schema compiler, column names in Hebrew letters are trimmed and a empty key dimension is generated.

To Reproduce Steps to reproduce the behavior:

  1. Generate a schema with the schema compiler in localhost:4000/playground with Hebrew column names.
  2. You'll notice that generated dimensions key's that suppose to have Hebrew letters are empty.
cube(`TableNameWithHebrewColumnName`, {
  sql: `SELECT * FROM "TableName"."TableNameWithHebrewColumnName"`,
  
  preAggregations: {
    // Pre-Aggregations definitions go here
    // Learn more here: https://cube.dev/docs/caching/pre-aggregations/getting-started  
  },
  
  joins: {
    
  },
  
  
  dimensions: {
    formNumber: {
      sql: `${CUBE}."Form_Number"`,
      type: `number`
    },
   
    : {
      sql: `${CUBE}.`,
      type: `string`,
    },
  },
  
  dataSource: `default`
});

Expected behavior To have an object with hebrew letters.

expected :  "גיל " : {
                       sql: `${CUBE}.גיל `,
                       type: `string`,
                  } 

Version: @cubejs-backend/schema-compiler : 0.30.45

貢獻者指南