cssinjs/jss

[react-jss] Observable rules/values

Open

#995 建立於 2019年1月20日

在 GitHub 查看
 (10 留言) (0 反應) (0 負責人)JavaScript (7,000 star) (434 fork)batch import
bugcomplexity:moderatehelp wanted

描述

Expected behavior: Observables should work without explicitly passing link: true as options and should be part of the static stylesheet. And no dynamic stylesheet should be generated when only observables are used.

Describe the bug: Currently, observables are part of the static sheet but the user needs to pass link: true and a dynamic sheet will also be generated.

Codesandbox link: https://codesandbox.io/s/01ro5xn32p

Versions (please complete the following information):

  • jss: 10.0.0-alpha.8

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
ReactJSSobservablesCSS in JS
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
The issue reports that observables in react jss require the `link: true` option and generate a dynamic stylesheet unnecessarily. Investigate the JSS source code, particularly the handling of observables in static sheets. Look at the codesandbox link for reproduction. The fix likely involves modifying the sheet generation logic to only generate a static sheet when only observables are used and remove the need for `link: true` explicitly.