cssinjs/jss

UMD builds not working on import

Open

#1,567 建立於 2021年10月21日

在 GitHub 查看
 (6 留言) (0 反應) (0 負責人)JavaScript (7,000 star) (434 fork)batch import
bugcomplexity:lowhelp wanted

描述

Expected behavior: I'm trying to implement react-jss via CDN. Importing the UMD build via <script> tag should work out of the box.

Describe the bug: The module does not load and the console generates the error as follows:

Uncaught ReferenceError: module is not defined
    at react-jss.min.js:6
    at react-jss.min.js:1
    at react-jss.min.js:1

Reproduction:

CodeSandbox - loading react, react-dom, and react-jss

Versions:

  • jss: 10.8.1
  • browser: any

貢獻者指南

技術棧
javascriptreact
領域
frontendbuild system
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Understanding of UMD module formatBasic bundler configuration knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue is that the UMD bundle for react jss references `module` which is not defined in the browser. Investigate the Rollup configuration (likely `rollup.config.js` or `package.json` build scripts) to see how the UMD output is generated. Look for any missing `output.globals` or improper use of CommonJS. The fix may involve ensuring the bundle does not depend on `module` or adding a shim. Check the existing build setup and compare with other packages that successfully produce UMD bundles.