cssinjs/jss

themed useCreateStyles leaks style tags in StrictMode

Open

#1,332 建立於 2020年4月20日

在 GitHub 查看
 (1 留言) (1 反應) (0 負責人)JavaScript (7,000 star) (434 fork)batch import
bughelp wanted

描述

Expected behavior: <style> elements get disposed when re-rendering in StrictMode.

Describe the bug: When using themed styles (possibly prop-based as well) re-rendering a component using useStyles with a new theme will leak their <style> elements.

This is possibly due to useStyles managing the sheet during render but unmanaging it in a effect cleanup. A component can render multiple times (in concurrent and strict mode) before an effect is scheduled.

Codesandbox link: https://codesandbox.io/s/determined-wood-8d0s7?file=/src/App.js:513-622

Click "rerender" and see that the number of <style> element grows with every "rerender" click.

Versions (please complete the following information):

  • react-jss: 10.1.1
  • Browser [e.g. chrome, safari]: Chrome 81
  • OS [e.g. Windows, macOS]: Ubuntu 18.04
  • react: 16.13.1

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
React StrictModejss library
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
Focus on the `useStyles` hook in react jss. Investigate how it creates and disposes style sheets during render and effects. The bug likely arises because sheets are created during render but only disposed in an effect cleanup, which conflicts with React's StrictMode double rendering. Study the codesandbox reproduction and the relevant source files in the jss repository to understand the timing. Consider proposing to move sheet management to a side effect or use a ref to track renders.