cssinjs/jss

[react-jss] each re-render of component appends new rule with media query

Open

#1,044 建立於 2019年2月23日

在 GitHub 查看
 (1 留言) (3 反應) (0 負責人)JavaScript (7,000 star) (434 fork)batch import
bugcomplexity:highhelp wantedimportant

描述

Expected behavior: There's computed style with media query (&:hover etc..)

Describe the bug: Each re-render of component appends new rule with media query

Codesandbox link: https://codesandbox.io/s/7yxv3r5jp1 (see to console)

Versions (please complete the following information):

  • jss: 10.0.0-alpha.10
  • Browser chrome
  • OS macOS

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
ReactJSS basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The bug is that each re render appends a new CSS rule with media queries instead of updating the existing one. The provided CodeSandbox reproduces the issue. To fix, investigate how react jSS handles dynamic styles and media queries in its JSS wrapper. Look at how styles are injected in the render method of the component using withStyles or createUseStyles. The duplication likely comes from the way the JSS sheet is managed when re rendering.