cssinjs/jss

[core] sheet.addRule with media query after attachment

Open

#1,038 建立於 2019年2月17日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)JavaScript (7,000 star) (434 fork)batch import
bugcomplexity:highhelp wanted

描述

Expected behavior: I should be able to create a style sheet, attach it to the dom and add a rule to a media query rule.

Describe the bug: Currently, the rule is added virtually but isn't rendered.

Codesandbox link: https://codesandbox.io/s/w66v8p8m35

Versions (please complete the following information):

  • jss: 9, 10
  • Browser chrome
  • OS macOS

貢獻者指南

技術棧
javascriptcss
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic knowledge of JSS
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the `sheet.attach()` and `sheet.addRule()` methods in JSS source code to understand why rules added after attachment are not rendered in the DOM. The provided codesandbox reproduces the issue; focus on how rules are inserted into the style element and why media query rules might be skipped. Look at the `insertRule` function and the `toCSS` method for media queries.