crytic/slither

[Bug]: all statements with `.` are reported as external calls

Open

#2,073 建立於 2023年8月1日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Python (4,769 star) (886 fork)batch import
buggood first issue

描述

Describe the issue:

I ran slither . --print function-summary to view external calls for functions. The resulting "External Calls" column treats any statement with a . as an external call. This includes solidity built-ins like abi.encode, library accesses like Address.sendValue, and struct field accesses.

Code example to reproduce the issue:

git clone https://github.com/scopelift/pooltogether-governor-upgrade/
cd pooltogether-governor-upgrade
forge install
slither . --print function-summary

Version:

0.9.6

Relevant log output:

No response

貢獻者指南

技術棧
python
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
PythonSolidity syntaxStatic analysis concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Examine the function summary printer in `slither/printers/` to see how external calls are identified. Look for logic that treats any expression with a '.' as an external call, and distinguish between built in functions like abi.encode, library calls, and struct field accesses. The fix should filter out non external calls by checking the call target's type.