corejavascript/typeahead.js

Deduplication of common/utils

Open

#165 建立於 2017年10月10日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (956 star) (232 fork)batch import
enhancementhelp wanted

描述

Up until version 0.10.x, common/utils was shared by Bloodhound & Typeahead.

From version 0.11.x onwards, Bloodhound & Typeahead are defined as UMD modules, and each module has its own copy of common/utils. This results in unnecessary redundancy / bloat.

There's several solutions for this. Personally, I lean towards one of these options :

  • Put common/utils into a third module that is used as a dependency by both Bloodhound & Typeahead
  • Replace common/utils by two distinct util classes that are no longer shared between Bloodhound & Typeahead

What do you guys think about this?

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptUnderstanding of UMD modulesFamiliarity with the repository structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue proposes deduplicating 'common/utils' which is currently copied in both Bloodhound and Typeahead modules. Investigate the 'common/utils' directory in the repository to understand the shared utilities. Then evaluate the two proposed solutions: creating a third shared module or splitting the utilities into distinct classes. Look at the existing module definitions in the codebase to see how dependencies are managed.