conventional-changelog/commitlint

Error when working from within a branch worktree

Open

#787 建立於 2019年9月13日

在 GitHub 查看
 (13 留言) (0 反應) (0 負責人)TypeScript (15,497 star) (896 fork)batch import
bughelp wanted

描述

When trying to run commitlint from within a branch worktree directory, I get the following error: could not find git root from undefined

Expected Behavior

The operation should succeed without error.

Current Behavior

The operation errors with could not find git root from undefined

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Steps to Reproduce (for bugs)

  1. Checkout a repo
  2. Checkout a different branch into a separate folder via worktree: git worktree add -b my-branch ../my-branch
  3. CD into the branch folder
  4. Make some changers
  5. Try to commit

Your Environment

Executable Version
commitlint --version 8.1.0
git --version git version 2.20.1.windows.1
node --version v10.14.1

貢獻者指南

技術棧
typescript
領域
cli
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
git worktree conceptcommitlint internalsTypeScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate how commitlint resolves the git root. The error suggests that the git root detection returns undefined in worktree directories. Check the source code in the CLI package, likely in the `@commitlint/cli` or `@commitlint/load` module, where `git rev parse show toplevel` is called. Consider using ` git common dir` or ` path format` to handle worktrees. Refer to linked PRs or comments for prior discussion. Also examine existing tests for git root resolution.