conductor-oss/conductor

APIs throwing 500 status when 4** is expected

Open

#172 建立於 2024年5月28日

在 GitHub 查看
 (7 留言) (0 反應) (2 負責人)Java (31,816 star) (894 fork)batch import
bughelp wanted

描述

Describe the bug When trying to delete a non-existing workflow using DELETE {{conductorBaseUrl}}/api/metadata/workflow/:name/:version api replies back with 500 status code.

{
    "status": 500,
    "message": "No such workflow definition: memes_maker version: 2",
    "instance": "1a79daf01f84",
    "retryable": false
}

Details Conductor version: v3.19.0 Persistence implementation: Postgres Queue implementation: Postgres Lock: I guess redis

To Reproduce Steps to reproduce the behavior:

  1. Use API to delete non existing workflow
curl --location --request DELETE 'http://localhost8080/api/metadata/workflow/memes_maker/2'
  1. See error

Expected behavior Status code should be 404

Additional context Same thing happens if we try to create existing workflow with existing version.

貢獻者指南

技術棧
javaspring
領域
backendapi
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The issue is that the DELETE endpoint for non existing workflow definitions returns a 500 status code instead of 404. Look at the workflow metadata resource controller (likely in a class like WorkflowMetadataResource.java) and find the delete method. The exception handling for 'No such workflow definition' should be caught and returned as a 404 response. The fix is simple: change the error response status from 500 to 404. The relevant code is probably in the Conductor server module.