combust/mleap

Reenable LDA parity spec

Open

#169 建立於 2017年4月6日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Scala (1,461 star) (312 fork)batch import
bughelp wanted

描述

LDA uses a random sampling to score data. This causes slightly different values to to be generated between each run, which makes testing outright equality of tensors a no-go for the parity spec.

We are temporarily disabling the LDA parity spec in favor of fixing tensor equality and will reenable the parity spec using lighter equality restrictions at a later time before the 0.7.0 release.

See the tensor equality issue here: https://github.com/combust/mleap/pull/156

貢獻者指南

技術棧
scala
領域
machine learningtesting
議題類型
test
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ScalaMLeap basicstesting
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Review PR #156 for the tensor equality fix. Locate the LDA parity spec file (likely LdaParitySpec.scala) and modify the test assertions to use approximate equality instead of exact tensor equality. Consider using a tolerance based comparison to account for random sampling variation. Re enable the spec before the 0.7.0 release.