codex-team/editor.js

`inlineToolbar` always show convertTo, inconsist behavior with config value, and cannot be removed

Open

#2,833 建立於 2024年9月29日

在 GitHub 查看
 (4 留言) (1 反應) (0 負責人)TypeScript (26,602 star) (1,985 fork)batch import
buggood first issue

描述

Describe a bug.

const editor = new EditorJS({
  holder: 'editor',
  tools: {
    paragraph: {
      // built-in inline tools: link, bold, italic
      // disable inline tools: false,
      inlineToolbar: ['bold', 'link'],
    },
  },
})

Expected behavior:

convertTo should also follow inlineToolbar config, which control it show or hide.

Screenshots:

image

As you see, it even show when no convertor available.

Device, Browser, OS:

Editor.js version:

Plugins you use with their versions:

貢獻者指南

技術棧
typescriptjavascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic knowledge of JavaScriptFamiliarity with Editor.js configuration
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
Investigate the inline toolbar component to understand how the convertTo button visibility is controlled. Look at the configuration merging logic to ensure that when `inlineToolbar` is explicitly set, the convertTo should respect that configuration. Check if there is a missing check for the availability of convertors. The relevant files are likely in `src/components/inline toolbar.ts` and `src/components/tools.ts`.
`inlineToolbar` always show convertTo, inconsist behavior with config value, and cannot be removed · codex-team/editor.js#2833 | Good First Issue