codeigniter4/CodeIgniter4

Dev: replace type `mixed` with more specific types

Open

#6,310 建立於 2022年7月29日

在 GitHub 查看
 (11 留言) (0 反應) (0 負責人)PHP (4,492 star) (1,707 fork)batch import
devgood first issuehelp wanted

描述

Type mixed means object|resource|array|string|int|float|bool|null. https://www.php.net/manual/en/language.types.declarations.php#language.types.declarations.mixed

The current code base has a lot of type mixed in PHPDocs, But I think all of them are not correct.

And mixed prevents PHPStan level from increasing.

PHPStan’s rule level 6 isn’t satisfied with implicit mixed https://phpstan.org/writing-php-code/phpdoc-types#mixed

We need to replace type mixed with more specific types.

貢獻者指南

技術棧
無
領域
backend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
PHP basicsunderstanding of PHPDoc type declarationsfamiliarity with PHPStan
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Search the codebase for occurrences of `mixed` in PHPDoc comments (e.g., using grep or an IDE). Replace each with the most specific type as per PHP documentation (e.g., `string`, `int`, `array`). Refer to PHPStan's rule level 6 expectations. No linked PRs or maintainer questions as of now.