cockroachdb/cockroach

kv: expose byte limits through kv.Txn API

Open

#63,661 建立於 2021年4月14日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Go (32,150 star) (4,124 fork)batch import
A-kv-clientC-enhancementT-kvhelp wanted

描述

Currently, the kv.Txn API exposes key limits through the maxRows arg (which is poorly named) of its Scan and ReverseScan methods, but it does not expose an ability to impose a byte limit. Byte limits were introduced into the kv proto API in https://github.com/cockroachdb/cockroach/commit/417aa0843dbc1b816d7326cf223e141aa817bd30. However, because of this limitation in the kv.Txn API, users who want byte limits need to construct raw roachpb protos to be able to use them.

We should add byte limits to the kv.Txn and kv.DB API.

Jira issue: CRDB-6709

貢獻者指南

技術棧
go
領域
backenddatabase
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Go programmingdistributed systems basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The issue requests adding byte limits to the `kv.Txn` and `kv.DB` API. Begin by examining the existing implementation of key limits via `maxRows` in the `Scan` and `ReverseScan` methods. Review the referenced commit (417aa0843dbc1b816d7326cf223e141aa817bd30) which introduced byte limits in the kv proto API. Understand how byte limits are currently used at the proto level, then design an analogous interface at the `kv.Txn` level. Check the `roachpb` package for the proto definitions. There are no linked PRs, so the work is still open.