cmu-delphi/forecast-eval

Data downloading fails if score type is coverage or if summarizing across multiple locations

開放

#255 建立於 2023年3月31日

 (0 則留言) (0 個反應) (0 位負責人)R (3 個分叉)auto 404
good first issue

倉庫指標

星標
 (6 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

We see this error

Warning: Error in filter: Problem while computing `..1 = !is.na(Score) | target_end_date >= filterDate`.
Caused by error in `mask$eval_all_filter()`:
! argument "filterDate" is missing, with no default

filterOverAllLocations requires a filterDate arg, but when totaling across locations or looking at coverage scores, we don't pass filterOverAllLocations a filterDate.

createExportScoreDataFrame will need to be passed at least a date to use in the filter. The value should be dataCreationDate to match other score-generating logic.

Consider passing input$asOf as well and adding as-of data onto the exported dataframe, to more closely match what we're using in the plots.

貢獻者指南