cloudpipe/cloudpickle

0.8.0 3 tests fail

Open

#252 建立於 2019年3月7日

在 GitHub 查看
 (7 留言) (0 反應) (0 負責人)Python (1,407 star) (152 fork)batch import
bughelp wanted

描述

When building cloudpickle 0.8.0 package for openSUSE I have 3 test failures:

[   10s] =================================== FAILURES ===================================
[   10s] ___________ CloudPickleFileTests.test_pickling_special_file_handles ____________
[   10s] 
[   10s] self = <tests.cloudpickle_file_test.CloudPickleFileTests testMethod=test_pickling_special_file_handles>
[   10s] 
[   10s]     def test_pickling_special_file_handles(self):
[   10s]         # Warning: if you want to run your tests with nose, add -s option
[   10s]         for out in sys.stdout, sys.stderr:  # Regression test for SPARK-3415
[   10s] >           self.assertEqual(out, pickle.loads(cloudpickle.dumps(out)))
[   10s] E           AssertionError: <_pytest.capture.EncodedFile object at 0x7fc4acbcb6d0> != <_pytest.capture.EncodedFile object at 0x7fc4981be990>
[   10s] 
[   10s] tests/cloudpickle_file_test.py:98: AssertionError
[   10s] __________________ CloudPickleTest.test_pickling_file_handles __________________
[   10s] 
[   10s] self = <tests.cloudpickle_test.CloudPickleTest testMethod=test_pickling_file_handles>
[   10s] 
[   10s]     def test_pickling_file_handles(self):
[   10s]         out1 = sys.stderr
[   10s]         out2 = pickle.loads(cloudpickle.dumps(out1, protocol=self.protocol))
[   10s] >       self.assertEqual(out1, out2)
[   10s] E       AssertionError: <_pytest.capture.EncodedFile object at 0x7fc4acbcb710> != <_pytest.capture.EncodedFile object at 0x7fc4aa0ef150>
[   10s] 
[   10s] tests/cloudpickle_test.py:119: AssertionError
[   10s] _____________ Protocol2CloudPickleTest.test_pickling_file_handles ______________
[   10s] 
[   10s] self = <tests.cloudpickle_test.Protocol2CloudPickleTest testMethod=test_pickling_file_handles>
[   10s] 
[   10s]     def test_pickling_file_handles(self):
[   10s]         out1 = sys.stderr
[   10s]         out2 = pickle.loads(cloudpickle.dumps(out1, protocol=self.protocol))
[   10s] >       self.assertEqual(out1, out2)
[   10s] E       AssertionError: <_pytest.capture.EncodedFile object at 0x7fc4acbcb710> != <_pytest.capture.EncodedFile object at 0x7fc4aa179ed0>
[   10s] 
[   10s] tests/cloudpickle_test.py:119: AssertionError

0.7.0 didn't have any issues with these tests. Full build log: cloudpickle.txt

貢獻者指南

技術棧
python
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Pythonpytestunderstanding of pickle
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
The test failure occurs because pytest replaces sys.stdout and sys.stderr with custom EncodedFile objects during test execution. The tests compare the original and unpickled objects using equality, which fails because the objects are different instances. The fix may involve modifying the test to check for functional equivalence rather than identity, or using a context manager to restore original streams. Look at the test files tests/cloudpickle file test.py and tests/cloudpickle test.py, and consider reviewing the pytest capture mechanism.