cloudflare/boringtun

Keeping timers relative to start of tunnel initiation is confusing

Open

#309 建立於 2022年8月24日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)Rust (4,849 star) (321 fork)batch import
code qualitygood first issue

描述

Keeping timers this way means that for example update_session_timers takes a time_now param that's a Duration instead of an Instant. All entries in Tunn::timers are Durations when many of them are "the time that something happened" and idiomatically I think these would be better expressed as Instants.

貢獻者指南

技術棧
rust
領域
backend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Rust Duration/Instant typesboringtun codebase structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
The issue proposes reworking the timer system to use `Instant` instead of `Duration` for tracking when events occurred. Specifically, `update session timers` takes a `Duration` parameter for `time now` which should be an `Instant`. The `Tunn::timers` field stores `Duration` values that represent absolute times; these should be changed to `Instant`. The change will affect how timers are calculated relative to the tunnel start. Key files to examine include `tunnel.rs` and any module handling timers. The discussion in the issue may provide further insights on required changes.