claviska/jquery-minicolors

Swatch isn't selected when minicolors inits and input has a swatch color value

Open

#256 建立於 2018年8月16日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (955 star) (322 fork)batch import
BugHelp Wanted

描述

Steps to reproduce:

On an input field with a value of a color of a swatch, init the minicolors plugin. If you open minicolors you can see the swatch color isn't selected (if you type another value it is then selected)

This happens because on init updateFromInput is called and that doesn't do the logic of selecting the swatch instead it calls doChange but only when minicolors is initialized:

// Fire change event, but only if minicolors is fully initialized
    if(input.data('minicolors-initialized')) {
      doChange(input, value, opacity);
    }

I'm not sure why doChange isn't called always, if it's just for performance issue or if it's to fix some bugs but I see 2 possible solutions: add swatch selection logic to init or updateFromInput or always call doChange even if minicolors is initialiazing.

貢獻者指南

技術棧
javascripthtmlcss
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
JavaScriptjQueryUnderstanding of minicolors plugin
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
The issue is that the swatch color is not selected on initialization when the input has a matching color value. The bug is in the 'updateFromInput' function which conditionally calls 'doChange' only after initialization, skipping swatch selection logic. Look at the code around line where 'input.data('minicolors initialized')' is checked. Consider two approaches: either add swatch selection logic to 'updateFromInput' or always call 'doChange' during init. The fix is likely small and localized to that function.