cjoudrey/graphql-schema-linter

Non-null Int types for "first" argument are not accepted by rule "relay-connection-arguments-spec"

Open

#148 建立於 2018年9月7日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)JavaScript (669 star) (62 fork)batch import
enhancementhelp wanted

描述

The following queries all fail lint checks:

  notablePeople(first: Int!, after: ID): NotablePersonConnection!

  users(first: Int!, after: ID, where: UsersQueryWhereInput): UserConnection!
    @requireOneOfRoles(roles: [MODERATOR])

  notablePeopleEvents(
    first: Int!
    after: ID
    where: NotablePersonEventsQueryWhereInput
  ): NotablePersonEventConnection!

If I remove the !, they all pass. Should not non-null integer types be accepted?

貢獻者指南

技術棧
javascriptgraphql
領域
apitooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
basic GraphQL knowledgefamiliarity with graphql schema linter
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
55
研究方向
The issue is in the `relay connection arguments spec` rule which likely validates that connection fields have `first`/`last` arguments of type `Int`. The current implementation does not accept non null `Int!` types. Investigate the rule's source code in the repository (likely in `src/rules/relay connection arguments spec.js`) to understand how type checking is performed. The fix may involve allowing both `Int` and `Int!` by updating the type comparison logic. Check the GraphQL spec for Relay connections to confirm that non null `Int` is valid according to the spec.