christopherdro/react-native-calendar

Inconsistency in passing value to callbacks

Open

#54 建立於 2016年7月19日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (544 star) (250 fork)batch import
enhancementhelp wanted

描述

I spotted inconsistency in callback values. Namely these: onSwipePrep and onSwipeNext receive moment instance. onDateSelected receives date in plain string format.

Unifying this issue is essentially a breaking change, but it would be nice to be consistent.

貢獻者指南

技術棧
react native
領域
mobile
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
familiarity with react native calendar callbacksknowledge of moment.js
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the callback implementations in the source code to confirm which callbacks return moment instances and which return strings. The issue specifically mentions onSwipePrep, onSwipeNext, and onDateSelected. The fix would involve changing the callbacks to consistently return either moment objects or strings. Since this is a breaking change, consider adding a new prop or version. The repository is deprecated, so contribution may not be merged.