chakra-core/ChakraCore

Review feature switches/Remove old always on switches

Open

#6,415 建立於 2020年4月11日

在 GitHub 查看
 (1 留言) (2 反應) (0 負責人)JavaScript (9,000 star) (1,374 fork)batch import
Codebase QualityTaskhelp wanted

描述

ChakraCore contains numerous feature switches that in practise are never used - e.g. there's a switch to disable promises and one to disable proxies etc. Some of these bloat the codebase AND require runtime checks for whether they're enabled or not.

EDIT: we should also consider removing phase/option switches that are never used see #4311 for one example (though in that case it's an always on switch)

We should investigate removing some/several of the older ones that are unlikely to ever be switched off and all associated checks.

Note, see lib/Commmon/ConfigFlagsList.h for all switches as the place to start looking.

edit: The PR ref'd below makes a start at this but there's more to do.

貢獻者指南

技術棧
cpp
領域
backendperformance
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
over 1 week
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C++ programmingUnderstanding of ChakraCore codebaseFamiliarity with feature flagsBuild system knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
Start by examining the file lib/Common/ConfigFlagsList.h (noted in the issue) to identify feature switches that are always enabled. For each identified switch, trace its usage across the codebase to find runtime checks that can be removed. The issue references a previous PR that made a start; review that PR for guidance. Additionally, consider removing phase/option switches that are never used as mentioned in #4311. Ensure that removal does not affect the engine's functionality.