chakra-core/ChakraCore

[RegExp] Exceptions for RegExp in Annex B of the ES2017 spec shouldn't be applied when the "unicode" flag is present

Open

#518 建立於 2016年3月10日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (9,000 star) (1,374 fork)batch import
BugSeverity: 2help wanted

描述

Annex B.1.4 contains exceptions that allow web browsers to diverge from the normal RegExp grammar. These exceptions aren't allowed when the "unicode" flag is present, but our current implementation doesn't take this into account.

There are many exceptions, but a few examples would be:

  • PatternCharacter: {
  • CharacterClassEscape: [\d-a]
  • DecimalEscape: \3 when the number of capturing parentheses is less than 3
  • IdentityEscape: \h, \u
  • QuantifiableAssertion Quantifier: (?!.)+

The above should throw a SyntaxError when used as, e.g.,/{/u

貢獻者指南

技術棧
javascript
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic understanding of regular expressionsfamiliarity with ChakraCore regex parser
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Start by examining the regex parsing code in ChakraCore, likely in the src/Regex or similar directory. The issue describes specific exceptions in Annex B.1.4 that should not apply when the 'unicode' flag is present. Look for where these exceptions are implemented and add a check for the unicode flag to throw SyntaxError. The examples given (e.g., `/{/u`) can be used as test cases. Note that the issue is from 2016, so the codebase may have evolved; check recent commits or comments for any partial fixes.
[RegExp] Exceptions for RegExp in Annex B of the ES2017 spec shouldn't be applied when the "unicode" flag is present · chakra-core/ChakraCore#518 | Good First Issue