casesandberg/react-color

Propogate view from toggle button on ChromePicker

Open

#584 建立於 2019年2月5日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (11,679 star) (946 fork)batch import
enhancementhelp wanted

描述

The current view state of the ChromeFields input in ChromePicker is not externally accessible and makes it difficult to tie in with other components.

I suggest adding an onToggleView callback to pass the new "view" state as a parameter back up to its container. e.g: if(this.props.onToggleView){ this.props.onToggleView('hex'); }

貢獻者指南

技術棧
react
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
React basicsreact color API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
The issue requests adding an onToggleView callback to ChromePicker to pass the view state (e.g., 'hex') to the container. The change is localized to the ChromePicker component. Look at the existing props and how other callbacks like onChange are implemented. Examine the ChromeFields input to determine where the view state is toggled. Add a prop and invoke it with the new view value when the toggle button is clicked. No linked PRs or maintainer comments addressing this request.