casesandberg/react-color

Cant type in 4 or 8 letter color names in editable input anymore

Open

#552 建立於 2018年10月19日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)JavaScript (11,679 star) (946 fork)batch import
bughelp wanted

描述

On the react color demo page I am able to type in "blue" into any of the editable inputs and that is recognized as valid. Since this fix - https://github.com/casesandberg/react-color/commit/669bf040955d2b8ff82b491e1044d28fe80d06b5#diff-012ff5a8f8316a2507102ec918eaf81b I am not able to type in 4 or 8 letter color names. They return as invalid because of the length check. So while "red" or "yellow" works fine, "blue" or "gray" doesnt.

Is there a work around for this?

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
familiarity with Reactbasic string validation logic
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
The issue is caused by a commit that added a length check for color names. Examine the commit at https://github.com/casesandberg/react color/commit/669bf040955d2b8ff82b491e1044d28fe80d06b5 and locate the helper function that validates color names (likely in src/helpers/). The current check rejects names with lengths other than 3, 5, 6, or 7, but should allow any length (e.g., 4 for 'blue', 8 for 'gray'). To fix, remove or modify the length validation to accept all valid CSS color names. No existing PR or assignee, so it's open for contribution.