casesandberg/react-color

#FFF circle color picker selected state on white background

開放

#530 建立於 2018年8月24日

 (12 則留言) (1 個反應) (0 位負責人)JavaScript (921 個分叉)batch import
enhancementhelp wantedquestion

倉庫指標

星標
 (12,322 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

If you use a CirclePicker color of #fff (white) and put it on a white background, the box shadow color is white and the 'selected' circle that appears is also... white. This leaves you with basically an invisible color picker.

I would propose that if one of the CirclePicker colors is #fff then make the box shadow color #000 by default and change the 'selected' circle that appears to additionally include a #000 colored border on it.

I know I can override this with CSS but I feel this shouldn't need to be overridden.

I would make a 'pull request' to offer these changes for you but I don't quite understand how pull requests work. I don't get why it's asking me to compare branches when all I wish to do is submit a single file.

Edit With that said, how exactly do I override the default CSS? I attempted to copy react-color/lib/components/circle/circle.js and react-color/lib/components/circle/CircleSwatch but I just get an error any time I click the color...?

貢獻者指南