casesandberg/react-color

Photoshop HSV up/down arrow controls are not working correctly

Open

#385 建立於 2017年7月23日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (11,679 star) (946 fork)batch import
help wanted

描述

When using arrow up/down keys on the (S)aturation field, the Value fields jumps to 0. After this, losing focus of the Saturation field will have it jump back to 0 too, because the Value is 0 and the actual color value updates the color picker. You can see the docs page to confirm this.

貢獻者指南

技術棧
javascriptreacthtmlcss
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Reactfamiliarity with color models
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the Photoshop color picker component in `src/components/photoshop/Photoshop.js`. The bug is related to HSV input fields. Look at how the `Saturation` and `Value` fields interact with keyboard events. The issue reports that using arrow up/down on Saturation causes Value to jump to 0 and losing focus reverts it. Consider adding proper state updates and validation to prevent the Value from being incorrectly set to 0 when Saturation changes. There are no linked PRs or comments, so the fix is open. Ensure that the color conversion functions in `src/helpers/color.js` are correctly used.