cake-build/cake

Tool.Run should make stdout and stderr available on failure

Open

#2,460 建立於 2019年1月24日

在 GitHub 查看
 (4 留言) (2 反應) (0 負責人)C# (3,742 star) (738 fork)batch import
Help wantedImprovementUp-for-grabs

描述

Tool.Run and related should make stdout and stderr available so that some analysis is possible on failure. Currently it calls ProcessExitCode which throws a simple CakeException.

Ideally, it would capture stdout and stderr and throw a CakeProcessException, or similar, that has additional properties for exit code, stdout and stderr.

貢獻者指南

技術棧
csharp
領域
build systemtooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C#Cake build system basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The request is to modify the Tool.Run method in src/Cake.Core/Tooling/Tool.cs to capture stdout and stderr before throwing an exception. Currently, at line 119, ProcessExitCode is called, and at line 139, a simple CakeException is thrown. The improvement is to create a new exception class CakeProcessException that includes exit code, stdout, and stderr. The implementation should capture the standard output/error from the process. A suggested approach is to use ProcessStartInfo.RedirectStandardOutput and RedirectStandardError before starting the process, then read the output streams before checking the exit code. The new exception should be thrown instead of CakeException. This is a well defined change with concrete file references.