bumbu/svg-pan-zoom

Uncaught errors thrown by events targeting children of a <foreignObject> element

Open

#51 建立於 2014年7月16日

在 GitHub 查看
 (7 留言) (0 反應) (0 負責人)JavaScript (1,585 star) (383 fork)batch import
bughelp wanted

描述

I'm working on a project which requires text wrapping and the approach I'm taking here is to embed an XHTML document inside a <foreignObject> element, as below.

<g>
  <polygon points="..."></polygon>
  <foreignObject>
    <body>
      <p>Blah blah, lorem ipsum something</p>
    </body>
  </foreignObject>
</g>

Now this renders just fine, panning is functional etc. but errors are thrown by events targeting anything inside the <foreignObject> element as neither evt.target.ownerSVGElement or evt.target.correspondingElement.ownerSVGElement are defined for these elements.

I've hacked in a "fix" which walks up the document tree until they are defined, but I doubt (in my limited experience with SVG/XML) that's a valid approach for much outside of a narrow use case so there's no pull request here.

貢獻者指南

技術棧
javascripthtml
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Basic knowledge of SVG DOMEvent handling in JavaScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Examine the event handling code in svg pan zoom.js, specifically where it accesses evt.target.ownerSVGElement. The issue occurs when events target elements inside a <foreignObject>, which are not direct SVG children. A robust fix would involve traversing the DOM tree upward until an SVG element is found, e.g., using evt.target.closest('svg') or a while loop checking ownerSVGElement. Ensure the fix handles all event types and does not introduce regressions. Review the existing comments (7) for any prior attempts or suggestions.
Uncaught errors thrown by events targeting children of a <foreignObject> element · bumbu/svg-pan-zoom#51 | Good First Issue