bumbu/svg-pan-zoom

minZoom and maxZoom not updated when updateBBox( ) is called

Open

#267 建立於 2017年10月26日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (1,585 star) (383 fork)batch import
bughelp wanted

描述

Expected behaviour

When adding new elements to the SVG that fall outside the current BBox, and calling updateBBox(), i should be able to zoom out to see those elements

Actual behaviour

The amount that I can zoom out is still based on the original BBox, meaning that i may not be able to zoom out to see all elements, even if minZoom is <1

Steps to reproduce the behaviour

  1. activate the lib on an SVG with minZoom: 1
  2. add elements outside the SVG's outer edge
  3. call updateBBox()
  4. try to zoom out to see the new elements

Note: Although it feels a bit weird to have them diverge, I'm not sure that the maximum zoom level should be affected by removing elements in the same way -- it would feel kinda strange to not be able to zoom into existing elements just because new ones have been added

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptsvg pan zoom APISVG coordinate system
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Examine the 'updateBBox' function in the library source code to understand how it handles viewport bounds. Current behavior suggests that minZoom and maxZoom are set only during initialization and not recalculated when the bounding box changes. The fix should ensure that after updateBBox, the zoom limits are recalculated based on the new bbox, allowing minZoom to be adjusted below 1 if needed. Check relevant comments in the issue #267 for additional context.