Add ability to pass ELEMENT to thumbnailViewer · bumbu/svg-pan-zoom#264

2017-10-13T16:15:36.000Z

Feature Request --- - Feature requested: Add the ability to pass an ELEMENT (not only an ID) to thumbnailViewer. - Reasons for adopting new feature: If we load SVG dynamically and want to use a thumbnailViewer, it's very hard to do so. - Is this a breaking change? It should not affect the functionality. Thank you!

(0 留言) (0 反應) (0 負責人)JavaScript (1,585 star) (383 fork)batch import

enhancementhelp wanted

描述

Feature Request

Feature requested: Add the ability to pass an ELEMENT (not only an ID) to thumbnailViewer.
Reasons for adopting new feature: If we load SVG dynamically and want to use a thumbnailViewer, it's very hard to do so.
Is this a breaking change? It should not affect the functionality.

Thank you!

貢獻者指南

技術棧: javascript
領域: frontend
議題類型: feature
難度: 2
預計時間: 1-3 hours
活動狀態: stale
清晰度: mostly clear
前置要求: JavaScript basics
新手友善度: 60
研究方向: Examine the thumbnailViewer function, likely in src/thumbnail viewer.js or similar. Understand how it currently accepts an ID (string) and modify it to also accept an element node. Ensure backward compatibility and consider updating documentation and adding tests for both ID and element inputs.