brave/brave-browser

The keyboard layout is wrong when defining a shortcut

Open

#47,764 建立於 2025年7月19日

在 GitHub 查看
 (0 留言) (3 反應) (0 負責人)JavaScript (16,194 star) (2,164 fork)batch import
OS/DesktopOS/Linuxfeature/keyboard-shortcutshelp wantedpriority/P5

描述

Description

when defining a now shorcut, brave seems to use a querty layout, while my keyboard is azerty

Steps to reproduce

  1. add a new shortcut
  2. tap a key combinaison (example ctrl + a)

Actual result

ctrl + q is shown on the screen

Expected result

ctrl + a should be shown instead

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.80.122 Chromium: 138.0.7204.157 (Build officiel) (64 bits) Révision d9aff5c5def33bd27a6ae282e7b3e90e9bd9cfa2 Système d'exploitation Linux

(flatpak)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

貢獻者指南

技術棧
javascriptcpp
領域
frontendlocalization
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic JavaScriptfamiliarity with keyboard events
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Investigate the shortcut definition UI in Brave's frontend code, likely in files under `app/` or `components/` that handle keyboard event capturing. Look for where key events are mapped to display strings. The issue is that the current implementation assumes QWERTY layout. Test with AZERTY layout on Linux. Consider using `event.code` vs `event.key`; the former is layout independent. A fix might involve using `event.code` for display or detecting the keyboard layout. Check existing Chromium issues for similar bugs.