brave/brave-browser

Unable to remove the "Focus menu bar" keyboard shortcut

Open

#47,302 建立於 2025年7月1日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (16,194 star) (2,164 fork)batch import
OS/DesktopOS/Windowsfeature/keyboard-shortcutshelp wantedpriority/P5

描述

Description

I'm trying to remove the default keybindings assigned to the "Focus menu bar" keyboard shortcut, and while I am able to do so with F10 and AltGr, when I try to remove the Alt keybinding it's never removed permanently. Like, it'll stay removed when I remove it but whenever Brave has to restart for whatever reason (e.g. system restart, Brave update) the "Focus menu bar" keyboard shortcut will be set to Alt again and I'll have to remove it again.

Steps to reproduce

  1. Remove all keybindings from the "Focus menu bar" keyboard shortcut
  2. Restart Brave using brave://restart
  3. Look at the keybindings for "Focus menu bar" keyboard shortcut

Actual result

Alt is set as a keybinding for the "Focus menu bar" keyboard shortcut

Expected result

Alt is not set as a keybinding for the "Focus menu bar" keyboard shortcut

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave: 1.80.113 Chromium: 138.0.7204.49 (Official Build) (64-bit) Revision: 253bb9512609910f855ef4f6075ceb87c79b1822 OS: Windows 11 Version 24H2 (Build 26100.4349)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

I have not ticked the "Is reproducible in the lastest version of Chrome" checkbox because AFAIK this is not a feature in Google Chrome.

貢獻者指南

技術棧
javascripthtmlcss
領域
frontendbackenddesktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with Brave's preference systemKnowledge of keyboard shortcut UI code
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Investigate how the 'Focus menu bar' shortcut is stored in Brave's preferences. The bug suggests that removing the Alt keybinding does not persist across restarts. Look at the code that saves keyboard shortcut settings, likely in brave/browser/ui/webui/settings/shortcuts handler.cc or similar. Check if there is a default shortcut that is reapplied on startup. Also review the preference observer to ensure removal is saved correctly.
Unable to remove the "Focus menu bar" keyboard shortcut · brave/brave-browser#47302 | Good First Issue