brave/brave-browser
Shortcut in the commander show incorrect key binding order instead of the originally created order
開放
#43,129 建立於 2025年1月6日
OS/DesktopQA/Test-Plan-SpecifiedQA/Yesfeature/keyboard-shortcutsgood first issuepolishpriority/P5
倉庫指標
- 星標
- (16,194 顆星)
- PR 合併指標
- (平均合併 4小時 38分鐘) (30 天內合併 19 個 PR)
描述
Description
Found while testing https://github.com/brave/brave-browser/issues/41412. Created shortcut key binding Ctrl + Shift + E in brave://settings/system/shortcuts for Export all bookmarks. However, this key binding order in commander is not same and it's shown as Shift + Ctrl + E. But both key bindings work to export bookmarks.
Steps to reproduce
- Install 1.75.145
- launch Brave
- opened
brave://settings/system/shortcuts - created a key binding
Ctrl + Shift + E - opened a new tab and pressed
Ctrl + Spacebaror hamburger menu >>Quick commands - type
Export all bookmarks
Actual result
Shift + Ctrl + E is shown
| example | example |
|---|---|
Expected result
correct order should be shown i.e. Ctrl + Shift + E
Reproduces how often
Easily reproduced
Brave version (brave://version info)
Brave | 1.75.145 Chromium: 132.0.6834.57 (Official Build) nightly (64-bit)
-- | --
Revision | 4ecdecd1626892f9f317e9d8154c50cf8459d3bf
OS | Windows 11 Version 24H2 (Build 26100.2605)
Channel information
- release (stable)
- beta
- nightly
Reproducibility
- with Brave Shields disabled
- with Brave Rewards disabled
- in the latest version of Chrome
Miscellaneous information
@fallaciousreasoning @rebron